[
https://issues.apache.org/jira/browse/LUCENE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455872#comment-13455872
]
Steven Rowe commented on LUCENE-4384:
-------------------------------------
bq. Should we keep this name 'ant precommit' or another idea is 'ant check' ?
I like 'ant precommit' better than 'ant check'. Even for non-committers
producing patches this makes sense, I think, since their patch will be
committed.
'ant check' is also very vague, where 'ant precommit' is not, since it ties the
action to a specific part of the workflow.
bq. as far as the symlink'd python for javadocs-lint, i think you can just add
your definition to your ~/build.properties (for any symlinked executables where
you have this issue) and you wont have any issues or have to pass them with -D
Right, but for me these are roughly interchangeable, since I set {{$ANT_OPTS}}
in my {{.bashrc}}.
> add top-level 'ant precommit'
> -----------------------------
>
> Key: LUCENE-4384
> URL: https://issues.apache.org/jira/browse/LUCENE-4384
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
> Attachments: LUCENE-4384.patch, LUCENE-4384.patch
>
>
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the
> (reasonably fast) checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses,
> forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
