[ 
https://issues.apache.org/jira/browse/LUCENE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457773#comment-13457773
 ] 

Michael McCandless commented on LUCENE-4404:
--------------------------------------------

That's a good point about the bit-stealing: I forgot it did that.  So I agree 
the new ListOfOutputs will likely make a larger FST ... but it shouldn't be so 
bad since it's only on the node-final outputs that it adds a byte.  Also it's 
more general (can wrap any output (not just PositiveInt), can hold an arbitrary 
number).

So I'll revive UpToTwoPositiveIntOutputs, and move it to misc (nobody actually 
uses it today... I think BlockTree had used it at one point), and put this new 
ListOfOutputs into misc too.
                
> Add ListOfOutputs FST Outputs, replacing UpToTwoPositiveIntOutputs
> ------------------------------------------------------------------
>
>                 Key: LUCENE-4404
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4404
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>         Attachments: LUCENE-4404.patch
>
>
> Spinoff from LUCENE-3842.  This just generalizes the
> UpToTwoPositiveIntOutputs to a list of any arbitrary output, by
> wrapping any other Outputs impl.  I also made separate methods to
> write/read a node-final output: since list of values can only occur on
> a final node output, this impl optimizes and avoids writing an extra
> byte per label for normal arc labels.
> This also fixes a bug in Builder that was sometimes failing to join
> multiple outputs together.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to