[ 
https://issues.apache.org/jira/browse/SOLR-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459727#comment-13459727
 ] 

James Dyer commented on SOLR-3857:
----------------------------------

Mikhail,

Based on reading the wiki, I imagine the purpose would be if the child entity 
was a lookup table where not all the keys were used but some of the keys join 
to many parent rows.  This would save it from having to read and cache the 
entire table if not the whole table is needed.  Also, it would prevent any key 
from being read more than once from the db.

This sounds like a very narrow use-case and I'm tempted to say that this 
feature is removed in 4.0 (and was broken in 3.6)!  On the other hand, someone 
somewhere is probably using it and its very much technically feasible.  So I'd 
hate to take away something just because the first implementation was poor and 
re-implementing it would be a little work.  Then again, if it depends on me to 
be fixing this, I'm not so sure it'll be ready for 4.0...

I also still have significant test-case re-writing yet to do so who knows what 
other bugs I can find doing that.  Hopefully no more but I have seen sporatic 
complaints from users that 3.6/4.0 isn't working exactly like 3.5 and prior.  
                
> DIH: SqlEntityProcessor with "simple" cache broken
> --------------------------------------------------
>
>                 Key: SOLR-3857
>                 URL: https://issues.apache.org/jira/browse/SOLR-3857
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: James Dyer
>
> The wiki describes a usage of CachedSqlEntityProcessor like this:
> {code:xml}
> <entity name="y" query="select * from y where xid=${x.id}" 
> processor="CachedSqlEntityProcessor">
> {code}
> This creates what the code refers as a "simple" cache.  Rather than build the 
> entire cache up-front, the cache is built on-the-go.  I think this has 
> limited use cases but it would be nice to preserve the feature if possible.
> Unfortunately this was not included in any (effective) unit tests, and 
> SOLR-2382 entirely broke the functionality for 3.6/4.0-alpha+ .  At a first 
> glance, the fix may not be entirely straightforward.
> This was found while writing tests for SOLR-3856.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to