[ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462692#comment-13462692 ]
Robert Muir commented on LUCENE-4425: ------------------------------------- Currently the responsibility is on the codecs to always allocate new things in this visitor API. This keeps the API simple (like String.toCharArray doing a copy does). We should proceed with caution: StoredFieldVisitor is essentially part of our .document API (despite its packaging, .index is wrong, sorry) and a parameter passed to IndexReader.document. I think making this api more complicated for no real gain would be the wrong tradeoff. > Unclear documentation of StoredFieldVisitor.binaryValue > ------------------------------------------------------- > > Key: LUCENE-4425 > URL: https://issues.apache.org/jira/browse/LUCENE-4425 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 4.0 > Reporter: Adrien Grand > Priority: Minor > Fix For: 4.1, 5.0 > > > When reading the binary value of a stored field, a StoredFieldsReader calls > StoredFieldVisitor.binaryValue(arr, offset, length). > Documentation currently doesn't state whether the byte[] can be reused > outside of the scope of {{StoredFieldVisitor.binaryValue}} but > {{DocumentStoredFieldVisitor}} assumes (as of r1389812) that it can. > So {{DocumentStoredFieldVisitor}} would break with a custom > {{StoredFieldsFormat}} that would call {{StoredFieldVisitor.binaryValue}} > with a slice of a reusable buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org