[ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463070#comment-13463070 ]
Mark Miller commented on SOLR-3861: ----------------------------------- Looks like as Yonik says in SOLR-3884, the final shutdown commit is explicit not something that comes from auto commit. And the searcher we may try to open and get a rejeceted execution on, is done after commit anyway. So I'm back to really not thinking this is a problem. The refactoring work done in the last patch is much better then what we have though. > regresion of SOLR-2008 - updateHandler should be closed before > searcherExecutor > ------------------------------------------------------------------------------- > > Key: SOLR-3861 > URL: https://issues.apache.org/jira/browse/SOLR-3861 > Project: Solr > Issue Type: Bug > Affects Versions: 4.0-ALPHA, 4.0-BETA > Reporter: Hoss Man > Assignee: Mark Miller > Priority: Blocker > Fix For: 4.1, 5.0 > > Attachments: SOLR-3861.patch, SOLR-3861.patch, SOLR-3861.patch > > > SOLR-2008 fixed a possible RejectedExecutionException by ensuring that > SolrCore closed the updateHandler before the searcherExecutor. > [~markrmil...@gmail.com] re-flipped this logic in r1159378, which is > annotated as fixing both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's > not clear why - pretty sure this means that the risk of a Rejected exception > is back in 4.0-BETA... > https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org