[ https://issues.apache.org/jira/browse/LUCENE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463736#comment-13463736 ]
Robert Muir commented on LUCENE-4428: ------------------------------------- Thanks Mike! I thought there was a good chance this would find a bug... but apparently we are ok? Lets get this in anyway. > add jar metadata testing to smokeTester > --------------------------------------- > > Key: LUCENE-4428 > URL: https://issues.apache.org/jira/browse/LUCENE-4428 > Project: Lucene - Core > Issue Type: Test > Components: general/test > Reporter: Robert Muir > Assignee: Michael McCandless > Attachments: LUCENE-4428.patch > > > It would be nice if the smokeTester could verify the metadata inside the > jars/wars we release, things like the following in META-INF/MANIFEST.MF: > * Implementation-Vendor: The Apache Software Foundation > * X-Compile-Source-JDK: 1.6 <-- check they used a 1.6 actual compiler > * X-Compile-Target-JDK: 1.6 <-- check that classes are the right format > * Specification-Version: 4.0.0 <-- should match release version > There should also exist META-INF/LICENSE.txt and META-INF/NOTICE.txt and they > should be correct (e.g. the solr one should not have lucene's or whatever). > I think we could use some code similar to what Mike did on SOLR-3879 to do > this. The only difference is that inside the solr.war, we are only interested > in lucene-xxx and apache-solr-xxx jar files (not third party ones). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org