[ 
https://issues.apache.org/jira/browse/LUCENE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464753#comment-13464753
 ] 

Shai Erera commented on LUCENE-4440:
------------------------------------

Isn't there a way to ensure that NamedSPILoader would finish before forName() 
is accessed? If not, we need to add such check to every forName we have. Here's 
a proposal message:

{code}
    if (loader == null) {
      throw new IllegalStateException("you are probably calling this method 
from inside a Codec's ctor); you shouldn't!");
    }
{code}
                
> FilterCodec should take a delegate Codec in its ctor
> ----------------------------------------------------
>
>                 Key: LUCENE-4440
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4440
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/codecs
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4440.patch
>
>
> FilterCodec has a delegate() method through which an extension can return its 
> delegate Codec. This method is called on every Codec method. Adrien, on 
> LUCENE-4391, failed to pass a Codec in the ctor, since he couldn't called 
> Codec.forName().
> Instead, we should just pass e.g. new Lucene40Codec(). I'll post a patch 
> shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to