[
https://issues.apache.org/jira/browse/LUCENE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473265#comment-13473265
]
Shai Erera commented on LUCENE-4472:
------------------------------------
Patch looks good. One minor comment -- LiveIWC.setMaybeMergeAfterFlush()
contains a redundant 'a' in its javadocs --> ".. after a each segment".
bq. Maybe the setting should mean we never call maybeMerge implicitly?
Perhaps the issue's description should change to "Add setting to prevent
merging on segment flush". Because as I understand the fix, the check is made
only after a segment has been flushed, which already covers
addDocument/updateDocument as well as future field updates?
> Add setting that prevents merging on updateDocument
> ---------------------------------------------------
>
> Key: LUCENE-4472
> URL: https://issues.apache.org/jira/browse/LUCENE-4472
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4472.patch
>
>
> Currently we always call maybeMerge if a segment was flushed after
> updateDocument. Some apps and in particular ElasticSearch uses some hacky
> workarounds to disable that ie for merge throttling. It should be easier to
> enable this kind of behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
