[ 
https://issues.apache.org/jira/browse/LUCENE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477990#comment-13477990
 ] 

Robert Muir commented on LUCENE-4479:
-------------------------------------

with the current patch, 'ant precommit' fails:
{noformat}
...
-ecj-javadoc-lint-src:
 [ecj-lint] Compiling 45 source files
 [ecj-lint] ----------
 [ecj-lint] 1. ERROR in 
/Users/rmuir/workspace/lucene-trunk/lucene/highlighter/src/java/org/apache/lucene/search/highlight/TokenSources.java
 (at line 275)
 [ecj-lint]     * @throws IOException
 [ecj-lint]               ^^^^^^^^^^^
 [ecj-lint] Javadoc: Description expected after this reference
 [ecj-lint] ----------
 [ecj-lint] 1 problem (1 error)

BUILD FAILED
{noformat}
                
> TokenSources.getTokenStream() doesn't return correctly for termvectors with 
> positions but no offsets
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4479
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4479
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 4.0
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4479.patch, LUCENE-4479.patch, LUCENE-4479.patch
>
>
> The javadocs for TokenSources.getTokenStream(Terms, boolean) state:
> "Low level api. Returns a token stream or null if no offset info available
> in index. This can be used to feed the highlighter with a pre-parsed token
> stream"
> However, if the Terms instance passed in has positions but no offsets stored, 
> a TokenStream is incorrectly returned, rather than null.
> This has the effect of incorrectly highlighting fields with term vectors and 
> positions, but no offsets.  All highlighting markup is prepended to the 
> beginning of the field.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to