[ 
https://issues.apache.org/jira/browse/LUCENE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490177#comment-13490177
 ] 

Uwe Schindler commented on LUCENE-4519:
---------------------------------------

Can you add javadocs to FilterIterator, so the generics are more clear. It is 
confusing which one is the inner iterator's type and which one the outer's. I 
would propose to rename the params to be more clear, too. Like 
FilterIterator<T, InnerT>.
                
> IndexDocument methods should not use wildcards in their return types
> --------------------------------------------------------------------
>
>                 Key: LUCENE-4519
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4519
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>         Attachments: LUCENE-4519.patch
>
>
> {{public Iterable<? extends IndexableField> indexableFields()}} should be 
> replaced with {{public Iterable<IndexableField> indexableFields()}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to