[
https://issues.apache.org/jira/browse/LUCENE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492892#comment-13492892
]
Chris Male commented on LUCENE-4542:
------------------------------------
Rafał,
Thanks for creating the patches, they are looking great. Couple of very small
improvements:
- Can we mark recursionCap as final?
- Can we improve the javadoc for the recursionCap parameter so it's clear what
purpose it serves?
- Maybe also drop in a comment at the field about how the recursion cap of 2 is
the default value based on documentation about Hunspell (as opposed to
something we arbitrarily chose).
> Make RECURSION_CAP in HunspellStemmer configurable
> --------------------------------------------------
>
> Key: LUCENE-4542
> URL: https://issues.apache.org/jira/browse/LUCENE-4542
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.0
> Reporter: Piotr
> Assignee: Chris Male
> Attachments: LUCENE-4542.patch, LUCENE-4542-with-solr.patch
>
>
> Currently there is
> private static final int RECURSION_CAP = 2;
> in the code of the class HunspellStemmer. It makes using hunspell with
> several dictionaries almost unusable, due to bad performance (f.ex. it costs
> 36ms to stem long sentence in latvian for recursion_cap=2 and 5 ms for
> recursion_cap=1). It would be nice to be able to tune this number as needed.
> AFAIK this number (2) was chosen arbitrary.
> (it's a first issue in my life, so please forgive me any mistakes done).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
