[
https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498511#comment-13498511
]
James Dyer commented on SOLR-4086:
----------------------------------
I don't believe it fixes all of SOLR-1916, and certainly doesn't eliminate all
the forbidden API's (that API checker is very handy, by the way). But I think
this takes a good bite out of it and hopefully soon we can remove the DIH
exclusion.
We might also be able to eventually run DIH tests in parallel also now that
SOLR-4051 gives the ability to specify the location of the
"dataimport.properties" file. Tests need to be changed to take advantage first
though.
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its
> own class. Compiler warnings / missing generics are fixed. Also, the Locale
> bug with DateFormatEvaluator is solved. Instead of using the machine
> default, the Root Locale is used by default. An optional 3rd parameter
> allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
