[ 
https://issues.apache.org/jira/browse/LUCENE-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504854#comment-13504854
 ] 

Robert Muir commented on LUCENE-4236:
-------------------------------------

There's a lot of things i'm not happy with in the patch, i think it was more of 
an exploration of ideas.

I think we could split out the cost/hitcount/conjunctionscorer idea into a 
separate issue as a start?

This would keep things contained.
                
> clean up booleanquery conjunction optimizations a bit
> -----------------------------------------------------
>
>                 Key: LUCENE-4236
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4236
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>             Fix For: 4.1
>
>         Attachments: LUCENE-4236.patch, LUCENE-4236.patch, LUCENE-4236.patch, 
> LUCENE-4236.patch
>
>
> After LUCENE-3505, I want to do a slight cleanup:
> * compute the term conjunctions optimization in scorer(), so its applied even 
> if we have optional and prohibited clauses that dont exist in the segment 
> (e.g. return null)
> * use the term conjunctions optimization when optional.size() == 
> minShouldMatch, as that means they are all mandatory, too.
> * don't return booleanscorer1 when optional.size() == minShouldMatch, because 
> it means we have required clauses and in general BS2 should do a much better 
> job (e.g. use advance).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to