[ 
https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505132#comment-13505132
 ] 

Hoss Man commented on SOLR-2052:
--------------------------------

Aaron: I don't really know/understand why the restriction is currently in 
place, but the fact that existing tests pass when you remove it doesn't in and 
of itself fill me with tons of confidence that it's definitely safe.

If you could add some tests to the patch demonstrating a codepath where both 
the Query filter and the DocSet filter get used, then i would be convinced 
(even just having a low level test that directly instantiated a 
SolrIndexSearcher.QueryCommand using both and executed demonstrating correct 
behavior would be re-assuring)
                
> Allow for a list of filter queries and a single docset filter in 
> QueryComponent
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2052
>                 URL: https://issues.apache.org/jira/browse/SOLR-2052
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 4.0-ALPHA
>         Environment: Mac OS X, Java 1.6
>            Reporter: Stephen Green
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: SOLR-2052-2.patch, SOLR-2052-3-6-1.patch, 
> SOLR-2052-3.patch, SOLR-2052-4_0_0.patch, SOLR-2052-4.patch, SOLR-2052.patch, 
> SOLR-2052-trunk.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries 
> or a single filter (as a DocSet), but not both.  This restriction seems 
> arbitrary, and there are cases where we can have both a list of filter 
> queries and a DocSet generated by some other non-query process (e.g., 
> filtering documents according to IDs pulled from some other source like a 
> database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both 
> of these to be set for a QueryCommand and to take both into account when 
> evaluating the query.  It also requires a modification to ResponseBuilder to 
> allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to