On Fri, Nov 30, 2012 at 8:29 AM, Michael McCandless < luc...@mikemccandless.com> wrote:
> > > 2) Could you perhaps clarify the use of the second argument in the > javadocs? > > Maybe also rename it to something like "fail if closing"? The name > > "includePendingClose" is vague perhaps consider*?) > > I agree that current name is no good! failIfClosing seems good? > > +1. a boolean for ensureOpen is intimidating: fixing up the param name/documentation here makes it easier to understand. I had no idea what this boolean was doing from the current code/explanation: but shai's explanation makes sense.
