[
https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509543#comment-13509543
]
Shai Erera commented on LUCENE-4580:
------------------------------------
bq. In SimpleSearcher the code is changed as such the DrillDown.query() always
takes a new FacetSearchParams()
I think that the example code was just misleading. The FacetSearchParams are
initialized in another method and used there, over the default indexing params.
Notice how searchWithDrillDown calls searchWithRequest(null), which initializes
default FacetIndexingParams. Since you cannot really execute faceted search
without FacetSearchParams (you need to at least add FacetRequests), I think
that having at least FSP on DrillDown API is ok. The API already has too many
duplicates IMO.
bq. In the tests, perhaps use Float.MIN_VALUE or 0f when asserting equality of
floats instead against 0.00000.
I don't assert against 0.00000, but against 0.0f. The 0.00000 part is for the
precision requires by assertEquals when you use doubles or floats.
> Facet DrillDown should return a ConstantScoreQuery
> --------------------------------------------------
>
> Key: LUCENE-4580
> URL: https://issues.apache.org/jira/browse/LUCENE-4580
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Priority: Minor
> Attachments: LUCENE-4580.patch
>
>
> DrillDown is a helper class which the user can use to convert a facet value
> that a user selected into a Query for performing drill-down or narrowing the
> results. The API has several static methods that create e.g. a Term or Query.
> Rather than creating a Query, it would make more sense to create a Filter I
> think. In most cases, the clicked facets should not affect the scoring of
> documents. Anyway, even if it turns out that it must return a Query (which I
> doubt), we should at least modify the impl to return a ConstantScoreQuery.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
