[ 
https://issues.apache.org/jira/browse/SOLR-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510534#comment-13510534
 ] 

Per Steffensen edited comment on SOLR-4114 at 12/5/12 3:35 PM:
---------------------------------------------------------------

Agree with everything you just said!

bq. But when I see arguments to add an e.g. 60 second test like this, I felt 
the need to speak up

I understand, and it is not that I like this kind of test! I just want the 
feature tested and protected from someone else ruining it tomorrow. And I cant 
come up with another way of testing that nothing happens, than wait for a 
while, and assert that it did not. And IMHO unit-tests directly on 
OverseerCollectionProcessor is not enough to ensure that the functionality seen 
as a whole from the outside will not be broken - and it IS the main concern (if 
we had a real customer :-) )
                
      was (Author: steff1193):
    Agree with everything you just said!

bq. But when I see arguments to add an e.g. 60 second test like this, I felt 
the need to speak up

I understand, and it is not that I this kind of test! I just want the feature 
tested and protected from someone else ruining it tomorrow. And I cant come up 
with another way of testing that nothing happens, than wait for a while, and 
assert that it did not. And IMHO unit-tests directly on 
OverseerCollectionProcessor is not enough to ensure that the functionality seen 
as a whole from the outside will not be broken - and it IS the main concern (if 
we had a real customer :-) )
                  
> Collection API: Allow multiple shards from one collection on the same Solr 
> server
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4114
>                 URL: https://issues.apache.org/jira/browse/SOLR-4114
>             Project: Solr
>          Issue Type: New Feature
>          Components: multicore, SolrCloud
>    Affects Versions: 4.0
>         Environment: Solr 4.0.0 release
>            Reporter: Per Steffensen
>            Assignee: Per Steffensen
>              Labels: collection-api, multicore, shard, shard-allocation
>         Attachments: SOLR-4114.patch, SOLR-4114.patch, SOLR-4114.patch, 
> SOLR-4114.patch, SOLR-4114_trunk.patch
>
>
> We should support running multiple shards from one collection on the same 
> Solr server - the run a collection with 8 shards on a 4 Solr server cluster 
> (each Solr server running 2 shards).
> Performance tests at our side has shown that this is a good idea, and it is 
> also a good idea for easy elasticity later on - it is much easier to move an 
> entire existing shards from one Solr server to another one that just joined 
> the cluter than it is to split an exsiting shard among the Solr that used to 
> run it and the new Solr.
> See dev mailing list discussion "Multiple shards for one collection on the 
> same Solr server"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to