[
https://issues.apache.org/jira/browse/LUCENE-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4598:
-------------------------------
Attachment: LUCENE-4598.patch
Patch sets liveDocs=null with a comment and proper javadocs.
While not related to this issue, I noticed that PayloadIterator copies the
payload BytesRef to its own buffer. This, I think, is a remnant from the days
where TP.getPayload took a byte[]. This is a redundant copy which must be
eliminated.
Mike, I wonder if that'd speed things up (only a bit, I know)?
Anyway, I'm not at all sure that it's worth duplicating MultiDAPE's logic into
this class. But at any rate, I think that this patch needs to be committed, to
remove the redundant byte[] copies.
Also, I noticed that CategoryListIterator (and PayloadIterator) define an
init() method which must be called prior to using them, and there's even a jdoc
comment saying that calling it twice may skip over documents ... I don't think
that we need it? Can't CLI impls initialize at ctor? At least, PayloadIterator
can. I'll open a separate issue for that.
> Facet aggregation should work per segment
> -----------------------------------------
>
> Key: LUCENE-4598
> URL: https://issues.apache.org/jira/browse/LUCENE-4598
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Michael McCandless
> Attachments: LUCENE-4598.patch
>
>
> Currently the facet module uses MultiFields.* to pull the D&PEnum in
> PayloadIterator, to access the payloads that store the facet ords.
> It then makes heavy use of .advance and .getPayload to visit all docIDs in
> the result set.
> I think we should get some speedup if we go segment by segment instead ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
