Thank you. It is nice that we have that bot, if we can improve it, it will get better!
Uwe Mark Miller <[email protected]> schrieb: >I'll look at making some mods with this feedback. > >- Mark > >On Dec 9, 2012, at 5:35 AM, Uwe Schindler <[email protected]> wrote: > >> Hi, >> >> One other thing is: The bot does not take the full commit message, >e.g. if it spawns multiple lines, it misses the later ones. Also it >does not add the merge messages my client generally adds, e.g.: >> >> Merged revision(s) 1417694 from lucene/dev/trunk: >> LUCENE-4589: Upgraded benchmark module's Nekohtml dependency to >version 1.9.17, removing the workaround in Lucene's HTML parser for the >Turkish locale >> >> The first line is missing. This may not be important but I don’t like >my commit message be stripped down and possibly important parts left >out. I generally try to format the commit messages, sometimes with new >paragraphs and so on. >> >> Also it seems to have problems with Multi-Issue commits. >> >> In my opinion, the bot should copy the *whole* commit message to all >issue-ids listed anywhere in the message (regex /(LUCENE|SOLR)\-\d+/) >and *not* try to parse the message. >> >> Uwe >> >> ----- >> Uwe Schindler >> H.-H.-Meier-Allee 63, D-28213 Bremen >> http://www.thetaphi.de >> eMail: [email protected] >> >> From: Doron Cohen [mailto:[email protected]] >> Sent: Sunday, December 09, 2012 11:26 AM >> To: [email protected] >> Subject: commit message format for tag bot >> >> Hi, >> >> It is great that the tag bot is adding back those commit version >numbers to JIRA. >> >> Just noticed the tag bot did not take a message formatted like this: >> LUCENE-4588 (cont): some text >> >> Assuming it would take multiple messages per issue, it probably >accepts only this format: >> LUCENE-4588: (cont) - some text >> >> So I'll format the message "correctly" next time, and perhaps add the >two missing continuation commits manually (needed to know them for >merging to 4x). >> >> Just thought I'll share this with others.. >> >> Doron > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [email protected] >For additional commands, e-mail: [email protected] -- Uwe Schindler H.-H.-Meier-Allee 63, 28213 Bremen http://www.thetaphi.de
