[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529065#comment-13529065 ]
Renaud Delbru edited comment on LUCENE-4613 at 12/11/12 5:52 PM: ----------------------------------------------------------------- {quote} Yes I think it'd be even better. You can use _TestUtil#randomSimpleString(Random, int maxLength). {quote} In fact, using random segment suffix is very difficult to achieve, as we cannot ensure that the codec instantiated through SPI will get the same segment suffix as the codec instantiated in the {{TestCompressingStoredFieldsFormat#setUp()}}, and therefore the {{_TestUtil#checkIndex(Directory dir)}} will fail. The segment suffix must be deterministic, e.g., similar to the current solution using the formatName as segment suffix. was (Author: renaud.delbru): {quote} Yes I think it'd be even better. You can use _TestUtil#randomSimpleString(Random, int maxLength). {quote} In fact, using random segment suffix is very difficult to achieve, as we cannot ensure that the codec instantiated through SPI will get the same segment suffix as the codec instantiated in the {{TestCompressingStoredFieldsFormat#setUp()}, and therefore the {{_TestUtil#checkIndex(Directory dir)}} will fail. The segment suffix must be deterministic, e.g., similar to the current solution using the formatName as segment suffix. > CompressingStoredFieldsWriter ignores the segment suffix if writing aborted > --------------------------------------------------------------------------- > > Key: LUCENE-4613 > URL: https://issues.apache.org/jira/browse/LUCENE-4613 > Project: Lucene - Core > Issue Type: Bug > Components: core/codecs > Affects Versions: 4.1 > Reporter: Renaud Delbru > Fix For: 4.1 > > Attachments: LUCENE-4613.patch, LUCENE-4613.patch > > > If the writing is aborted, CompressingStoredFieldsWriter does not remove > partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org