[ https://issues.apache.org/jira/browse/SOLR-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529512#comment-13529512 ]
Ryan McKinley commented on SOLR-4167: ------------------------------------- can we remove the non-static version and remove the /!\ NOTE /!\ from the static javadocs? > cleanup DocumentBuilder class/javadoc > ------------------------------------- > > Key: SOLR-4167 > URL: https://issues.apache.org/jira/browse/SOLR-4167 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > > Looking at org.apache.solr.update.DocumentBuilder, it seems like the javadocs > are out of date for how thigns are used. > It looks like the only function that is actually used is: > {code:java} > static Document toDocument( SolrInputDocument doc, IndexSchema schema ) > {code} > The static/non-thread safe version is never used > The javadoc comment: > {code} > TODO: /!\ NOTE /!\ This semantics of this function are still in flux. > {code} > seems out of date since this is the function that is actually used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org