[ 
https://issues.apache.org/jira/browse/SOLR-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530112#comment-13530112
 ] 

Robert Muir commented on SOLR-4169:
-----------------------------------

{quote}
This would be an ideal situation, I agree. But then what would "unit" tests for 
Solr be?
{quote}

For instance: tests that test a query parser can just create that QP, and do:

{code}
Query expected = ...
assertEquals(expected, parser.parse(someString));
{code}

Just like unit tests everywhere else.

But nobody writes solr tests this way (i dont know why, ive definitely written 
such unit tests for solr components before).
Instead e.g. all the queryparser tests actually index documents and assert 
XPATH shit against the response.

This makes them significantly harder to debug for no good reason.
                
> The test suite should consistently pass
> ---------------------------------------
>
>                 Key: SOLR-4169
>                 URL: https://issues.apache.org/jira/browse/SOLR-4169
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Robert Muir
>            Priority: Blocker
>             Fix For: 4.1
>
>
> I'm at the end of my rope. 
> Last week I tried to help with this: but its already wednesday and solr tests 
> are 20x worse.
> Users are complaining that they cannot get snapshots and test them, because 
> the tests fail all the time.
> Maven dependencies are wrong, but we never knew, because the tests never 
> succeeded so the validation task hasn't actually run in months.
> I think fixing this situation is a blocker to release: I can't imagine a 
> bigger blocker actually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to