[ 
https://issues.apache.org/jira/browse/LUCENE-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530394#comment-13530394
 ] 

Robert Muir commented on LUCENE-4625:
-------------------------------------

AtomicReader already provides the way to do this with its cache keys.

I dont think we should move things like fieldcaches back to it.
                
> Make TotalFacetCounts per-segment
> ---------------------------------
>
>                 Key: LUCENE-4625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4625
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>
> TotalFacetCounts are used during complements computation today. They are not 
> per-segment and therefore are not NRT friendly. Even regardless to NRT, you 
> need to compute them entirely from scratch whenever you reopen IR.
> It would be good if we can develop them per-segment. If e.g. AtomicReader had 
> a notion of cachable objects, it could be such an object. That has been 
> discussed many times in the past though, without a consensus. So perhaps we 
> can have a FacetsAtomicReader which manages TFC. But that creates other 
> issues too, like who instantiates that AtomicReader (i.e. we'd need a 
> FacetsCompositeReader too, and potentially IW would need to init that type) 
> ...
> Let's explore these options, but in general it would be good to have TFC 
> per-segment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to