[ 
https://issues.apache.org/jira/browse/SOLR-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533472#comment-13533472
 ] 

Yonik Seeley commented on SOLR-4203:
------------------------------------

Trying to wrap my head around non-persistent Directories...

{code}
     initLog();
+    if (!core.getDirectoryFactory().isPersistent()) {
+      try {
+        clearLog();
+      } catch (IOException e) {
+        throw new RuntimeException(e);
+      }
+    }
{code}

Doing it this way seems tricky... The UpdateLog wasn't originally really 
written with rebooting in mind, and I don't know what traps might be there (and 
this may be the cause of tlog files that can't be removed under windows now).
Seems more straightforward to delete the directory before initializing the log.
Only tricky part there is finding out where the directory is.

Perhaps this clearing logic should just be done directly in the UpdateLog.init()


                
> An ephemeral directory implementation should cause the transaction log to be 
> ignored on startup.
> ------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4203
>                 URL: https://issues.apache.org/jira/browse/SOLR-4203
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-4203.patch
>
>
> If you are using something like ram dir, you can restart a node and if no 
> updates have come in, it will think its up to date but be empty - we should 
> clear the update log in these cases on startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to