[ 
https://issues.apache.org/jira/browse/SOLR-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-4085:
-----------------------------------

    Attachment: SOLR-4085.patch

added spin on race between lazy file loading and reload request. not absolutely 
accurate, and efficient, but should be reliable enough. see 
testSearchReloadRace. now race looks like (it's a test log)
{noformat} 
oassf.FileFloatSource.getFloats Loaded external value source 
external_test_make_a_pause_SOLR_4085_extf
oassf.FileFloatSource$ReloadFieldRequestHandler.handleRequestBody reloading 
field test_make_a_pause_SOLR_4085_extf
oassf.FileFloatSource$Cache.resetAllReaders WARNING concurrent lazy loading 
while reloading field: FileFloatSource.Key 
[field=test_make_a_pause_SOLR_4085_extf .. file will loaded again
oassf.FileFloatSource.getValues WARNING concurrent reload detected. load file 
again FileFloatSource.Key [field=test_make_a_pause_SOLR_4085_extf
oassf.FileFloatSource.getFloats Loaded external value source 
external_test_make_a_pause_SOLR_4085_extf
{noformat} 

race detection has a false positive case, which can be easily fixed. see 
comment at FileFloatSource.getValues().
                
> Commit-free ExternalFileField
> -----------------------------
>
>                 Key: SOLR-4085
>                 URL: https://issues.apache.org/jira/browse/SOLR-4085
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.1
>            Reporter: Mikhail Khludnev
>              Labels: externalfilefield
>         Attachments: SOLR-4085.patch, SOLR-4085.patch, SOLR-4085.patch
>
>
> Let's reload ExternalFileFields without commit!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to