[
https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539870#comment-13539870
]
Erik Hatcher commented on SOLR-4234:
------------------------------------
lol - while I like /admin/file and of course mixing and matching it with the
VelocityResponseWriter, I cringe at ZK serving up favicons.
But hey, better that it works for binary files than didn't, so +1 :)
One minor issue with the patch is the incorrect javadoc added to the
ByteArrayStream ctor "Construct a <code>ContentStream</code> from a
<code>File</code>", so let's get that correct.
> ZooKeeper doesn't handle binary files
> -------------------------------------
>
> Key: SOLR-4234
> URL: https://issues.apache.org/jira/browse/SOLR-4234
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Mark Miller
> Fix For: 4.1, 5.0
>
> Attachments: binary_upload_download.patch,
> fix_show_file_handler_with_binaries.patch
>
>
> I was attempting to get the ShowFileHandler to show a .png file, and it was
> failing. But in non-ZK mode it worked just fine! It took a while, but it
> seems that we upload to zk as a text, and download as well. I've attached a
> unit test that demonstrates the problem, and a fix. You have to have a
> binary file in the conf directory to make the test work, I put solr.png in
> the collection1/conf/velocity directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
