[
https://issues.apache.org/jira/browse/LUCENE-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542162#comment-13542162
]
Robert Muir commented on LUCENE-4649:
-------------------------------------
This is also related (in my opinion a big part of the problem) to LUCENE-4638.
The problem is that indexwriter relies upon certain types of exceptions (e.g.
ThreadInterruptedException) instead of checking interrupt status?
so if we fix this correctly, then in close() when trying to shut down merges
and so on it would handle ClosedByInterruptException correctly too.
> kill ThreadInterruptedException
> -------------------------------
>
> Key: LUCENE-4649
> URL: https://issues.apache.org/jira/browse/LUCENE-4649
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> the way we currently do this is bogus.
> For example in FSDirectory's fsync, i think we should instead:
> {noformat}
> } catch (InterruptedException ie) {
> - throw new ThreadInterruptedException(ie);
> + Thread.currentThread().interrupt(); // restore status
> + IOException e = new java.io.InterruptedIOException("fsync() interrupted");
> + e.initCause(ie);
> + throw e;
> {noformat}
> and crazy code in IndexWriter etc that catches ThreadInterruptedExc just to
> restore status should be removed.
> Instead the guy doing the catch (InterruptedException) should do the right
> thing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
