Here is my groovy way, like the lucene.javadoc.url. Unfortunately there is no way to apply a regex to a property value and assign it to a new one (see e.g., http://stackoverflow.com/questions/1176071/replacing-characters-in-ant-property)
Uwe ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: [email protected] > -----Original Message----- > From: Robert Muir [mailto:[email protected]] > Sent: Wednesday, January 02, 2013 6:36 PM > To: [email protected] > Subject: Re: [JENKINS-MAVEN] Lucene-Solr-Maven-4.x #198: POMs out of > sync > > I only know how to do it in a hacky way: > > Index: common-build.xml > ========================================================== > ========= > --- common-build.xml (revision 1427796) > +++ common-build.xml (working copy) > @@ -1350,6 +1350,13 @@ > </sequential> > </target> > > + <!-- nocommit: this is wrong to do! --> <condition > + property="lucene.maven.jar.pattern" > + value="lucene-*-${tests.luceneMatchVersion}-*.jar" > + else="lucene-*-${version}.jar"> > + <matches pattern="SNAPSHOT" string="${version}"/> </condition> > + > <target name="-validate-maven-dependencies"> > <property name="top.level.dir" location="${common.dir}/.."/> > <pathconvert property="pom.xml"> > @@ -1363,7 +1370,7 @@ > </pathconvert> > <m2-validate-dependencies pom.xml="${pom.xml}" > licenseDirectory="${license.dir}"> > <excludes> > - <rsel:name name="**/lucene-*.jar" handledirsep="true"/> > + <rsel:name name="**/${lucene.maven.jar.pattern}" > + handledirsep="true"/> > </excludes> > </m2-validate-dependencies> > </target> > > > On Wed, Jan 2, 2013 at 12:10 PM, Uwe Schindler <[email protected]> wrote: > > Hi, > > > > My idea with: <rsel:name name="**/lucene-*-${version}.jar" > > handledirsep="true"/> Does not work for standard builds, as the > ${version}=="5.0-SNAPSHOT" produces another filename (not ending in > SNAPSHOT, instead a random date-like number). This is caused by some > magic in the internet downloader: > > > > -validate-maven-dependencies: > > [licenses] MISSING sha1 checksum file for: C:\Users\Uwe > > Schindler\.m2\repository\org\apache\lucene\lucene-codecs\5.0- > SNAPSHOT\ > > lucene-codecs-5.0-20130102.164639-2.jar > > [licenses] MISSING sha1 checksum file for: C:\Users\Uwe > > Schindler\.m2\repository\org\apache\lucene\lucene-core\5.0- > SNAPSHOT\lu > > cene-core-5.0-20130102.164408-2.jar > > [licenses] Scanned 4 JAR file(s) for licenses (in 0.02s.), 2 error(s). > > > > That is the problem I have here. So maybe we need a regex as Robert > suggests. One for snapshot releases and one for builds with real version > numbers where the filenames can be guessed easily. > > > > Uwe > > > > ----- > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: [email protected] > > > > > >> -----Original Message----- > >> From: Robert Muir [mailto:[email protected]] > >> Sent: Wednesday, January 02, 2013 5:08 PM > >> To: [email protected] > >> Subject: Re: [JENKINS-MAVEN] Lucene-Solr-Maven-4.x #198: POMs out > of > >> sync > >> > >> On Wed, Jan 2, 2013 at 11:05 AM, Robert Muir <[email protected]> > wrote: > >> > On Wed, Jan 2, 2013 at 11:02 AM, Uwe Schindler <[email protected]> > >> wrote: > >> >> Hi, > >> >> > >> >> It is worse: The Maven build also download Lucene 3.6.0 (because > >> >> carrot > >> clustering depends on this). Our maven dependency checker does not > >> fail on this because we have an exclusion: > >> > ... > >> >> <excludes> > >> >> <rsel:name name="**/lucene-*.jar" handledirsep="true"/> > >> >> </excludes> > >> > ... > >> >> > >> >> We should fix this pattern in rsel:name to add the lucene version. > >> > >> In case it helps: we dont have to use the ant-style patterns. > >> rsel:name can take a regexp instead > >> > >> http://ant.apache.org/manual/Types/resources.html#rsel.name > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] For > >> additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] For > > additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For additional > commands, e-mail: [email protected]
strict-maven-version.patch
Description: Binary data
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
