[ https://issues.apache.org/jira/browse/LUCENE-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera resolved LUCENE-4647. -------------------------------- Resolution: Fixed Fix Version/s: 5.0 4.1 Lucene Fields: New,Patch Available (was: New) Committed changes to trunk and 4x. I'm sure there will be more improvements / simplifications to that API, we can do them incrementally. > Simplify CategoryDocumentBuilder > -------------------------------- > > Key: LUCENE-4647 > URL: https://issues.apache.org/jira/browse/LUCENE-4647 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Fix For: 4.1, 5.0 > > Attachments: LUCENE-4647.patch > > > CategoryDocumentBuilder is used to add facet fields to a document. Today the > usage is not so straightforward, and I'd like to simplify it. First, to > improve usage but also to make cutover to DocValues easier. > This clsas does two operations: (1) adds drill-down terms and (2) creates the > fulltree payload. Today, since it does it all on terms, there's a hairy > TokenStream which does both these operations in one go. For simplicity, I'd > like to break this into two steps: > # Write a TokenStream which adds the drill-down terms > #* For no associations, terms should be indexed w/ DOCS_ONLY (see > LUCENE-4623). > #* With associations, drill-down terms have payload too. > #* So EnhancementsDocumentBuilder should be able to extend this stream. > # Write some API which can be used to build the fulltree payload (i.e. > populate a byte[]). Currently that byte[] will be written to a payload and > later to DV. > Hopefully, I'd like to have FacetsDocumentBuilder (maybe just FacetsBuilder?) > which only handles things with no associations, and EnhancementsDocBuilder > which extends whatever is needed to add associations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org