[
https://issues.apache.org/jira/browse/SOLR-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-4300:
---------------------------------
Attachment: SOLR-4300.patch
Definitely a race condition. This patch includes a test case that fails before
the patch and succeeds after the patch. All tests pass.
The question is whether or not this should be put into the 4.1 release, or held
until 4.2. Of course I have the usual programmer's pride and want any of my
code included in a release to be as good as I can make it, but I'm also aware
of the hazards of including changes like this late in the game. Not sure this
will be widely enough used to warrant the risk....
I don't _think_ there is an infinite loop here (the sleep), but then I always
think my code is perfect. I think that if a core fails to load, the finally
block will allow other threads to continue. They'll fail also assuming the
underlying cause isn't fixed (say the lazily-loaded core configurations are
mal-formed XML). But that's not something I think should be addressed in the
code.
> Possible race condition in CoreContainer.getCore() when lazily loading cores.
> -----------------------------------------------------------------------------
>
> Key: SOLR-4300
> URL: https://issues.apache.org/jira/browse/SOLR-4300
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.1, 5.0
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Blocker
> Attachments: SOLR-4300.patch
>
>
> Yonik pointed out in SOLR-1028 that there is a possible race condition here,
> he's right not to my surprise. Calling it a "blocker" for now so we make a
> decision on it rather than let it fall through the cracks. I should be able
> to get a patch up tonight (Sunday).
> That said, there's potential here to introduce deadlocks, is it worth rushing
> into 4.1?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
