[ https://issues.apache.org/jira/browse/LUCENE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-4683: ------------------------------- Attachment: LUCENE-4683.patch * Added setNextReader to CategoryListIterator (instead of init()) and Aggregator. * Modified StandardFacetsAccumulator to iterate of the segment's atomic readers and call setNextReader accordingly. * Fixed an issue in ScoredDocIdsUtils where it assumed ScoredDocIDs are OpenBitSet where for a long time they are FixedBitSet. This caused unnecessary copy from FixedBitSet to OpenBitSet. * Most of the other changes are API changes, i.e. createCategoryListIterator no longer takes an IndexReader etc. I didn't add yet a CHANGES line because I'm not sure if this will make it into 4.1. Basically it's ready to go in (all tests pass), so I'll check later today what's the status of the 4.1 branch and decide accordingly. This now makes the cutover to DocValues even easier. That's what I'd like to do next. > Change Aggregator and CategoryListIterator to be per-segment > ------------------------------------------------------------ > > Key: LUCENE-4683 > URL: https://issues.apache.org/jira/browse/LUCENE-4683 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-4683.patch > > > As another improvement, these two (mostly CategoryListIterator) should be > per-segment. I've got a patch nearly ready, will post tomorrow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org