[
https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554113#comment-13554113
]
Erik Hatcher commented on SOLR-4234:
------------------------------------
I'm not a fan of this change:
{quote}
Index: example/solr/collection1/conf/velocity/header.vm
===================================================================
--- example/solr/collection1/conf/velocity/header.vm (revision 1433108)
+++ example/solr/collection1/conf/velocity/header.vm (working copy)
@@ -1,3 +1,3 @@
<div id="head">
- <span ><a
href="#url_for_home#if($request.params.get('debugQuery'))?debugQuery=true#end"><img
src="#{url_root}/img/solr.png" id="logo"/></a></span>
+ <span ><a
href="#url_for_home#if($request.params.get('debugQuery'))?debugQuery=true#end"><img
src="#{url_for_solr}/admin/file?file=/velocity/solr.png&contentType=image/png"
id="logo"/></a></span>
</div>
{quote}
This means that solr.png needs to be duplicated into every core's configuration
rather than coming from the Solr web app itself. I get this as an example of
serving a binary file from ZK, but let's not bake it into the collection1
example like this.
> Add support for binary files in ZooKeeper.
> ------------------------------------------
>
> Key: SOLR-4234
> URL: https://issues.apache.org/jira/browse/SOLR-4234
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.0
> Reporter: Eric Pugh
> Assignee: Mark Miller
> Fix For: 4.1, 5.0
>
> Attachments: binary_upload_download.patch,
> fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch,
> solr.png
>
>
> I was attempting to get the ShowFileHandler to show a .png file, and it was
> failing. But in non-ZK mode it worked just fine! It took a while, but it
> seems that we upload to zk as a text, and download as well. I've attached a
> unit test that demonstrates the problem, and a fix. You have to have a
> binary file in the conf directory to make the test work, I put solr.png in
> the collection1/conf/velocity directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
