[ https://issues.apache.org/jira/browse/SOLR-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558874#comment-13558874 ]
James Dyer commented on SOLR-4325: ---------------------------------- The test I've done here for this is clearly wrong. I looked quickly at oas.util.DateMathParser and do not see this as a problem with the parser. Also, DateMathParserTest#testParseMathTz is checking for DST issues. I will commit a test fix for DIH soon. > DIH DateFormatEvaluator seems to have problems with DST changes -> test > disabled > -------------------------------------------------------------------------------- > > Key: SOLR-4325 > URL: https://issues.apache.org/jira/browse/SOLR-4325 > Project: Solr > Issue Type: Bug > Components: contrib - DataImportHandler > Affects Versions: 4.0, 4.1 > Reporter: Uwe Schindler > Assignee: James Dyer > Fix For: 4.2, 5.0 > > > Yesterday was DST change in Fidji (clock went one hour backwards, as summer > time ended and winter time started). This caused > org.apache.solr.handler.dataimport.TestBuiltInEvaluators.testDateFormatEvaluator > to fail. The reason is simple: NOW-2DAYS is evaluated without taking time > zone into account (its substracting 48 hours), but to be correct and go 2 > DAYS back in local wall clock time, it must subtract only 47 hours. If this > is not intended (we want to go 48 hours back, not 47), the test needs a fix. > Otherwise the date evaluator must take the timezone into account when > substracting days (e.g., use correctly localized Calendar instance and use > the add() method > ([http://docs.oracle.com/javase/6/docs/api/java/util/Calendar.html#add(int, > int)]). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org