[ https://issues.apache.org/jira/browse/LUCENE-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561692#comment-13561692 ]
Michael McCandless commented on LUCENE-4691: -------------------------------------------- +1 > Facet tests should randomly pick IntEncoder and other stuff > ----------------------------------------------------------- > > Key: LUCENE-4691 > URL: https://issues.apache.org/jira/browse/LUCENE-4691 > Project: Lucene - Core > Issue Type: Test > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-4691.patch > > > Facets have many encoders already, but only one of them is tested by all > facet tests (the default). While {{EncodingTest}} covers all encoders, I > already fixed it because it didn't catch a bug where one encoder didn't reset > the given {{BytesRef}}. It will be useful if tests could choose a > randomCategoryListParams(), or randomFacetIndexingParams() etc., to swap in > random encoders. > Also, I wrote an AssertingCategoryListIterator which asserts all kind of > things (e.g. that if setNextReader returns false, getOrdinals isn't called). > Would be good to use it by all tests. > To do that, I think that it would be best if all facet tests extend a > FacetTestCase with such utility methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org