[
https://issues.apache.org/jira/browse/LUCENE-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4715:
-------------------------------
Attachment: LUCENE-4715.patch
* Patch adds OrdinalPolicy.NO_DIMENSION and modifies {{CountingListBuilder}} to
discard the last added ordinal (the dimension) in that case.
* CountingFacetsCollector modified to rollup parents' counts when dimensions
are indexed with NO_PARENTS.
* {{CategoryListParams.getOrdinals}} modified to take a String (dimension). The
default impl returns {{DEFAULT_ORDINAL_POLICY}} and PerDimensionOrdinalPolicy
supports returning different policies for different dimensions.
* OrdinalPolicy.NO_DIMENSION made the default, as usually the count of
dimension is not needed by apps.
** Note though that when children of the dimension are specified as the root
category of the {{FacetRequest}}, they will be counted too.
** For all practical purposes, {{NO_DIMENSION}} and {{ALL_PARENTS}} behave the
same by that they count whatever is encoded in the counting list, and don't fix
parents' counts in the end (nor check if a certain ordinal needs to be counted
or not).
All tests pass, I think this is ready.
> Add OrdinalPolicy.NO_DIMENSION
> ------------------------------
>
> Key: LUCENE-4715
> URL: https://issues.apache.org/jira/browse/LUCENE-4715
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-4715.patch
>
>
> With the move of OrdinalPolicy to CategoryListParams,
> NonTopLevelOrdinalPolicy was nuked. It might be good to restore it, as
> another enum value of OrdinalPolicy.
> It's the same like ALL_PARENTS, only doesn't add the dimension ordinal, which
> could save space as well as computation time. It's good for when you don't
> care about the count of Date/, but only about its children counts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]