[ 
https://issues.apache.org/jira/browse/LUCENE-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565359#comment-13565359
 ] 

Gilad Barkai commented on LUCENE-4715:
--------------------------------------

Looking at the patch, I think I might misunderstood something - in the build 
method, for every category the right policy is checked, but the build itself is 
per CategoryListParam - so why cant the policy be the same for each CLP? If one 
wishes to get different policies etc - I think it would be logical to separate 
them to different clps, and this check should not be performed over each 
category?


                
> Add OrdinalPolicy.NO_DIMENSION
> ------------------------------
>
>                 Key: LUCENE-4715
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4715
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4715.patch
>
>
> With the move of OrdinalPolicy to CategoryListParams, 
> NonTopLevelOrdinalPolicy was nuked. It might be good to restore it, as 
> another enum value of OrdinalPolicy.
> It's the same like ALL_PARENTS, only doesn't add the dimension ordinal, which 
> could save space as well as computation time. It's good for when you don't 
> care about the count of Date/, but only about its children counts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to