[ 
https://issues.apache.org/jira/browse/SOLR-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Wright updated SOLR-4390:
------------------------------

    Attachment: SOLR-4390.patch

Here's the naive patch, which does not concern itself at all with backwards 
compatibility.

If Mr. Hatcher is correct, and nobody uses SolrJ field names that are other 
than standard URL characters, this patch should suffice.  But if anyone wants a 
more nuanced approach, let me know and I will create parameters that have 
knowledge of whether or not they need encoding at the SolrJ level.

                
> SolrJ does not URL-encode query string argument names but should
> ----------------------------------------------------------------
>
>                 Key: SOLR-4390
>                 URL: https://issues.apache.org/jira/browse/SOLR-4390
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.1
>            Reporter: Karl Wright
>         Attachments: SOLR-4390.patch
>
>
> SolrJ does not appear to URL-encode any metadata names, but should.  This 
> leads to URLs that are illegal, and thus an IllegalArgumentException gets 
> thrown.  See CONNECTORS-630 for an example of a bad URL that SolrJ generates.
> I understand that this may have been broken for a long time and that now 
> backwards-compatibility is an issue, but it should still be possible to tell 
> SolrJ to do the right thing and not make the SolrJ user do it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to