[ 
https://issues.apache.org/jira/browse/LUCENE-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589556#comment-13589556
 ] 

l0co commented on LUCENE-2100:
------------------------------

A little comment from me, because I just need to use this.

I'm wondering why people in opensource projects so much like to complicate 
simple things and like to break the rules of OOP, making a lot obstacles for 
users, like package visibility, almost everything private, and making final 
classes or methods. This just prevents to quick use the existing code, override 
class and make anything you want with this the existing code.

It looks that this is because we should only use existing code, but not to 
change it any way, right?

I want to use PolishAnalyzer, which is already implemented, and add a simple 
improvement to this class, but I cannot do it now. I need to copy all existing 
class to my package and write there the extension.

Great "improvement" for me in this ticket.
                
> Make contrib analyzers final
> ----------------------------
>
>                 Key: LUCENE-2100
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2100
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 
> 2.9, 2.9.1, 3.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0-ALPHA
>
>         Attachments: LUCENE-2100.patch, LUCENE-2100.patch
>
>
> The analyzers in contrib/analyzers should all be marked final. None of the 
> Analyzers should ever be subclassed - users should build their own analyzers 
> if a different combination of filters and Tokenizers is desired.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to