[ 
https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated LUCENE-4642:
-------------------------------

    Description: 
All tokenizer implementations have a constructor that takes a given 
AttributeSource as parameter (LUCENE-1826).  These should be removed.

TokenizerFactory does not provide an API to create tokenizers with a given 
AttributeFactory, but quite a few tokenizers have constructors that take an 
AttributeFactory.  TokenizerFactory should add a create(AttributeFactory) 
method, as should subclasses for tokenizers with AttributeFactory accepting 
ctors.


  was:
All tokenizer implementations have a constructor that takes a given 
AttributeSource as parameter (LUCENE-1826). However, the TokenizerFactory does 
not provide an API to create tokenizers with a given AttributeSource.

Side note: There are still a lot of tokenizers that do not provide constructors 
that take AttributeSource and AttributeFactory.

    
> Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors 
> taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking 
> AttributeSource
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4642
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4642
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.1
>            Reporter: Renaud Delbru
>            Assignee: Steve Rowe
>              Labels: analysis, attribute, tokenizer
>             Fix For: 4.3
>
>         Attachments: LUCENE-4642.patch, LUCENE-4642.patch, LUCENE-4642.patch, 
> TrieTokenizerFactory.java.patch
>
>
> All tokenizer implementations have a constructor that takes a given 
> AttributeSource as parameter (LUCENE-1826).  These should be removed.
> TokenizerFactory does not provide an API to create tokenizers with a given 
> AttributeFactory, but quite a few tokenizers have constructors that take an 
> AttributeFactory.  TokenizerFactory should add a create(AttributeFactory) 
> method, as should subclasses for tokenizers with AttributeFactory accepting 
> ctors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to