[
https://issues.apache.org/jira/browse/LUCENE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-4752:
---------------------------------
Attachment: LUCENE-4752.patch
bq. But, since LTC is quite big, perhaps we can move these methods to a util,
e.g. CompareIndexes?
Why is the size of the class a concern? I think it's more convenient to have
all assert*Equals methods in the same class? (LuceneTestCase already has many
assert*Equals methods inherited from Assert.) And it makes these methods easier
to find when writing a test?
bq. Can we make OneMerge.readers private and add OneMerge.add(AtomicReader) for
IW to use? It looks odd that IW manipulates OneMerge.readers directly, but then
calls OneMerge.getMergeReaders()
I think it would be odd if getMergeReaders was just a getter but it is more
than that since it filters out empty readers and can even return an arbitrary
view over the readers to merge. But here it is just a method that computes data
based on the class members, like segString?
bq. Can we remove SegmentMerger.add()
Good point, I updated the patch.
> Merge segments to sort them
> ---------------------------
>
> Key: LUCENE-4752
> URL: https://issues.apache.org/jira/browse/LUCENE-4752
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/index
> Reporter: David Smiley
> Assignee: Adrien Grand
> Attachments: LUCENE-4752.patch, LUCENE-4752.patch, LUCENE-4752.patch,
> LUCENE-4752.patch
>
>
> It would be awesome if Lucene could write the documents out in a segment
> based on a configurable order. This of course applies to merging segments
> to. The benefit is increased locality on disk of documents that are likely to
> be accessed together. This often applies to documents near each other in
> time, but also spatially.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
