[ 
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607506#comment-13607506
 ] 

Uwe Schindler edited comment on LUCENE-4848 at 3/20/13 10:59 AM:
-----------------------------------------------------------------

Hi Michael,
in my previous patch I also added the new Directory implementation into the 
list of FSDirectories to be used randomly while testing (when tests.directory 
is not given). This is missing in the latest patch. It should simply be added 
to the list in LuceneTestCase.java:

{noformat}
   private static final List<String> FS_DIRECTORIES = Arrays.asList(
     "SimpleFSDirectory",
     "NIOFSDirectory",
-    "MMapDirectory"
+    "MMapDirectory",
+    "AsyncFSDirectory"
   );
{noformat}

I was not able to validate the thread exclusion lists, but Dawid will do this. 
Maybe he has an easier solutions, to me it looks too complicated.
                
      was (Author: thetaphi):
    Hi Michael,
in my previous patch I also added the new Directory implementation into the 
list of FSDirectories to be used randomly while testing (when tests.directory) 
is not given. This is missing in the latest patch. It should simply be added to 
the list:

{noformat}
   private static final List<String> FS_DIRECTORIES = Arrays.asList(
     "SimpleFSDirectory",
     "NIOFSDirectory",
-    "MMapDirectory"
+    "MMapDirectory",
+    "AsyncFSDirectory"
   );
{noformat}

I was not able to validate the thread exclusion lists, but Dawid will do this. 
Maybe he has an easier solutions, to me it looks too complicated.
                  
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, 
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on 
> JDK7).  These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any 
> changes requested.  I've included some minimal smoke tests, but any help in 
> how to use the normal Lucene tests to perform more thorough testing would be 
> appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to