[
https://issues.apache.org/jira/browse/LUCENE-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610871#comment-13610871
]
Commit Tag Bot commented on LUCENE-2163:
----------------------------------------
[branch_4x commit] Michael McCandless
http://svn.apache.org/viewvc?view=revision&revision=1383887
LUCENE-2163: remove unnecessary sync
> Remove synchronized from DirReader.reopen/clone
> -----------------------------------------------
>
> Key: LUCENE-2163
> URL: https://issues.apache.org/jira/browse/LUCENE-2163
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Michael McCandless
> Priority: Minor
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-2163.patch
>
>
> Spinoff from LUCENE-2161, where the fact that DirReader.reopen is
> sync'd was dangerous in the context of NRT (could block all searches
> against that reader when CMS was throttling). So, with LUCENE-2161,
> we're removing the synchronization when it's an NRT reader that you're
> reopening.
> But... why should we sync even for a "normal" reopen? There are
> various sync'd methods on IndexReader/DirReader (we are reducing that,
> with LUCENE-2161 and also LUCENE-2156), but, in general it doesn't
> seem like "normal" reopen really needs to be sync'd. Performing a reopen
> shouldn't incur any chance of blocking a search...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
