[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shawn Heisey updated SOLR-4586:
-------------------------------

    Attachment: SOLR-4586.patch

A new patch for 4x that allows setting maxBooleanClauses on the solr tag in 
solr.xml as well as each solrconfig.xml.  If solr.xml has the config, the 
others will be ignored.

The only way that the new 1 million plus default will actually get used is if 
the config option is missing entirely from both solr.xml and the first 
solrconfig.xml.

This is probably not the final patch.  I'd like to have it reviewed to see if 
used a good approach.

I still need to make some tests, but I will need help with that.  In 
particular, I do not know how to fire up a Jetty instance with custom configs - 
where to put the configs and how to tell the test to use them.  I can be easily 
reached on irc.

Once I come up with a final 4x patch, I will make a different one for trunk 
that removes the solrconfig.xml config option and only allows it to be set on 
the solr.xml/solr.properties, and modify the test(s) to match.
                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to