[
https://issues.apache.org/jira/browse/LUCENE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616264#comment-13616264
]
David Smiley commented on LUCENE-4742:
--------------------------------------
Node->Cell is committed on both branches, including a short note in the API
changes section of CHANGES.txt.
I'm not sure wether to take this further and have SpatialPrefixTree be
SpatialGrid. It makes sense for basically the same reason as Node->Cell, but
this class is more used and thus will more likely be breaking, and it also
triggers other possible renames like the prefix and prefix.tree packages, and
...PrefixTree... classes. Though it'd be nice to substitute the short 'n sweet
"Grid" for the longer and compound word "PrefixTree".
> Rename SpatialPrefixTree's "Node" back to "Cell"
> ------------------------------------------------
>
> Key: LUCENE-4742
> URL: https://issues.apache.org/jira/browse/LUCENE-4742
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Trivial
> Fix For: 4.3
>
> Attachments: LUCENE-4742_Rename_spatial_Node_back_to_Cell.patch
>
>
> SpatialPrefixTree makes "Node"s which are basically a rectangular spatial
> region that is more colloquially referred to as a "Cell". It was named
> "Cell" in the first place and for whatever reason, Ryan and/or Chris renamed
> it as part of extracting it to a top level class from an inner class. Most
> comments and variable names still use the "cell" terminology. I'm working on
> an algorithm that keeps track of a tree of "nodes" and it has gotten
> confusing which kind of node I'm referring to, as each Node has one cell.
> In maybe a week or so if there isn't discussion to the contrary, I'm going to
> commit a rename it back to "Cell". And... while we're on this naming
> subject, perhaps "SpatialPrefixTree" could be named "SpatialGrid" ? FWIW the
> variables referring to it are always "grid".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
