[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4893:
-------------------------------
Attachment: LUCENE-4893.patch
Patch addresses the following:
* FacetsCollector.getFacetResults() clears the matchingDocs list after
accumulator.compute returned.
* FacetsAccumulator creates an empty FacetResult for each FacetRequest if
matchingDocs.isEmpty(). I had to do it because FacetArrays still contained the
original counts, and so calling .getFacetResults twice yielded the same results
as before. But this is inconsistent with how StandardFacetsAccumulator works,
so I preferre\ed to return an empty FacetResult in both cases.
* Added a test case to TestFacetsCollector.
I think it's ready.
> Facet counts in FacetsAccumulator.facetArrays are multiplied as many times as
> FacetsCollector.getFacetResults is called.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4893
> URL: https://issues.apache.org/jira/browse/LUCENE-4893
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 4.2
> Reporter: crocket
> Attachments: LUCENE-4893.patch
>
>
> In lucene 4.1, only StandardFacetsAccumulator could be instantiated.
> And as of lucene 4.2, it became possible to instantiate FacetsAccumulator.
> I invoked FacetsCollector.getFacetResults twice, and I saw doubled facet
> counts.
> If I invoke it three times, I see facet counts multiplied three times.
> It all happens in FacetsAccumulator.accumulate.
> StandardFacetsAccumulator doesn't have this bug since it frees facetArrays
> whenever StandardFacetsAccumulator.accumulate is called.
> Is it a feature or a bug?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
