[
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618324#comment-13618324
]
Shai Erera commented on LUCENE-4893:
------------------------------------
That would mean FacetsCollector will need to track whether getFacetResults was
called or not, and distinguish that from "no results were found". I guess it
can be done by having matchingDocs set to null by getFacetResults(), and
initialized in setNextReader, so getFacetResults can check if matchingDocs is
null, and throw IllegalStateException indicating no search has been performed
yet (since or not the last call to getFacetResults). TopDocsCollector can be
fixed like that too, but I prefer in a separate issue.
> Facet counts in FacetsAccumulator.facetArrays are multiplied as many times as
> FacetsCollector.getFacetResults is called.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4893
> URL: https://issues.apache.org/jira/browse/LUCENE-4893
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 4.2
> Reporter: crocket
> Attachments: LUCENE-4893.patch, LUCENE-4893.patch
>
>
> In lucene 4.1, only StandardFacetsAccumulator could be instantiated.
> And as of lucene 4.2, it became possible to instantiate FacetsAccumulator.
> I invoked FacetsCollector.getFacetResults twice, and I saw doubled facet
> counts.
> If I invoke it three times, I see facet counts multiplied three times.
> It all happens in FacetsAccumulator.accumulate.
> StandardFacetsAccumulator doesn't have this bug since it frees facetArrays
> whenever StandardFacetsAccumulator.accumulate is called.
> Is it a feature or a bug?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
