[
https://issues.apache.org/jira/browse/SOLR-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631733#comment-13631733
]
Shalin Shekhar Mangar commented on SOLR-4566:
---------------------------------------------
The attached patch was committed to trunk and branch_4x along with the shard
split feature. If people are happy with the API proposed in the patch then we
can mark this issue as resolved.
> clusterstate#getSlices and getSlicesMap should always return all slices.
> ------------------------------------------------------------------------
>
> Key: SOLR-4566
> URL: https://issues.apache.org/jira/browse/SOLR-4566
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 4.3, 5.0
>
> Attachments: SOLR-4566.patch
>
>
> I'm not sure I really like this getSlices vs getAllSclies - it's kind of easy
> to get in trouble right now I think. Some spots that we clearly want to call
> getAllSlices got left with getSlices. It's almost surprising that getSlices
> only returns active replicas - it should probably at least be called
> getSlicesWithActive or something more explicit. But for the first step, we
> should just fix the various mis calls.
> There are a couple problems around the mis calls, the most severe probably
> being that you can lose shards that are not active from the clusterstate.json
> given the right races.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
