[ 
https://issues.apache.org/jira/browse/SOLR-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631786#comment-13631786
 ] 

Steve Rowe commented on SOLR-3251:
----------------------------------

Thanks for taking a look, Yonik.

{quote}
One thing I noticed quickly.... is there a reason this is synchronized?
{code:java}
      //Run the callbacks on SchemaAware now that everything else is done
      synchronized (schemaAware) {
        for (SchemaAware aware : schemaAware) {
          aware.inform(this);
        }
      }
{code}
{quote}

No, that's a vestige from when I had thought that access to the schema aware 
collection needed to be synchronized, I forgot to clean it up here.  I'll 
remove the synchronization.
                
> dynamically add field to schema
> -------------------------------
>
>                 Key: SOLR-3251
>                 URL: https://issues.apache.org/jira/browse/SOLR-3251
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Steve Rowe
>         Attachments: SOLR-3251.patch, SOLR-3251.patch, SOLR-3251.patch, 
> SOLR-3251.patch
>
>
> One related piece of functionality needed for SOLR-3250 is the ability to 
> dynamically add a field to the schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to