On Fri, Apr 19, 2013 at 8:25 AM, Uwe Schindler <u...@thetaphi.de> wrote:
> Hi, > > I am still reviewing. I have one note about the changes.txt where we miss > a backwards break: > > * https://issues.apache.org/jira/browse/LUCENE-4877 made the > AnalysisFactories require to have a non-default ctor, otherwise a > MethodNotFoundException is thrown on initializing the SPI. The new > constructor needs to have Map<String,String> parameters containing the > factory params (e.g. from schema.xml). This change affects all users that > wrote own factories for their own analysis components, so this should > really be mentioned in the Lucene changelog (maybe also in Solr). > Unfortunately the changes entry in CHANGES.txt only contains a simple note: > "LUCENE-4877: > Give me a break. the factory api was *already* broken in 4.3 before I even did this issue, by those AttributeSource api changes. No need to single out and overreact to my change, no backwards break was necessary since it already existed from another change.
