[ 
https://issues.apache.org/jira/browse/SOLR-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636731#comment-13636731
 ] 

Robert Muir commented on SOLR-2079:
-----------------------------------

{quote}
maybe a little risky, or at least something that needs to be warned about 
here... what if a component asked for the session from the request object? 
Wouldn't that cause sessions to be created within Solr and potentially consume 
resources?
{quote}

But this is just a brokenness with the servlet api that any user should be 
aware of: in this case the user didn't read the javadocs, they should have used 
getSession(false). If they don't read those javadocs, why would they read ours?
                
> Expose HttpServletRequest object from SolrQueryRequest object
> -------------------------------------------------------------
>
>                 Key: SOLR-2079
>                 URL: https://issues.apache.org/jira/browse/SOLR-2079
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers, search
>            Reporter: Chris A. Mattmann
>             Fix For: 4.3
>
>         Attachments: SOLR-2079.patch, SOLR-2079.patch, SOLR-2079.patch, 
> SOLR-2079.Quach.Mattmann.082310.patch.txt
>
>
> This patch adds the HttpServletRequest object to the SolrQueryRequest object. 
> The HttpServletRequest object is needed to obtain the client's IP address for 
> geotargetting, and is part of the patches from W. Quach and C. Mattmann.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to